surface any errors encountered during schema validation #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…schema-validation
|
Kudos, SonarCloud Quality Gate passed!
|
Azahorscak
approved these changes
Mar 1, 2023
nungster
approved these changes
Mar 2, 2023
sudermanjr
deleted the
sudermanjr/surface-json-marshal-errors-in-schema-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
What's the goal of this PR?
Currently, if the marshalling the file to JSON fails, reckoner returns a non-descriptive error.
This PR changes that error to:
What changes did you make?
Instead of passing the generic SchemaValidationError, we pass back the actual error. The SchemaValidationError is only used if there are actual schema validation errors.
What alternative solution should we consider, if any?
n/a